Typing inside proc-macro only changing trivia tokens re-expands proc-macro #17213
Labels
A-perf
performance issues
A-proc-macro
proc macro
C-Architecture
Big architectural things which we need to figure up-front (or suggestions for rewrites :0) )
C-enhancement
Category: enhancement
E-hard
Changing the comment content here currently invalidates relative spans in the macro input, invalidating the macro argument subtree as the contained spans change, and as such we re-expand the proc-macro even though logically the macro can't really observe this change unless it actually uses the proc-macro API to introspect spans. We should fix this by having the proc-macro server record whether an expansion did introspection or not and somehow instruct salsa that it shouldnt need to re-expand these queries in those cases.
The text was updated successfully, but these errors were encountered: