Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature Parameter offsets #296

Closed
kjeremy opened this issue Dec 19, 2018 · 2 comments
Closed

Signature Parameter offsets #296

kjeremy opened this issue Dec 19, 2018 · 2 comments
Labels
E-medium good first issue S-actionable Someone could pick this issue up and work on it right now

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Dec 19, 2018

Once #294 is merged ParameterInformation we will be able to return offsets into the SignatureInfo.label instead of a separate string (which is intended to be a substring of SignatureInfo.label). This would make the code a little simpler.

See https://microsoft.github.io/language-server-protocol/specification#textDocument_signatureHelp
@kjeremy kjeremy mentioned this issue Dec 19, 2018
Closed
7 tasks
@kjeremy kjeremy mentioned this issue Mar 11, 2019
Closed
@vipentti vipentti mentioned this issue Mar 12, 2019
Closed
@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 25, 2021
@categulario
Copy link

It looks like #294 is merged already. If this is still waiting for someone to do it I'd like to help.

@categulario
Copy link

This was probably solved in e1e79cf, consider closing the issue

@lnicola lnicola closed this as completed Mar 26, 2021
@QuieTResQ369 QuieTResQ369 mentioned this issue Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-medium good first issue S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lnicola @categulario @matklad @kjeremy