Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of VS-Code plugin from 0.2.546 to 0.2.554 causing cargo check failures on rust-lang/rust #8562

Closed
cbeuw opened this issue Apr 18, 2021 · 1 comment

Comments

@cbeuw
Copy link

cbeuw commented Apr 18, 2021

Possible duplicate of #8330.

With 0.2.554, rust-lang/rust@2fd73fa repo can't be checked properly with the following output:

[ERROR project_model::workspace] cyclic deps: rustc_std_workspace_core(CrateId(1157)) -> core(CrateId(195))
[ERROR project_model::workspace] cyclic deps: rustc_std_workspace_core(CrateId(1157)) -> core(CrateId(195))
[ERROR project_model::workspace] cyclic deps: rustc_std_workspace_core(CrateId(1157)) -> core(CrateId(195))
[ERROR rust_analyzer::reload] failed to switch build data: cargo check failed:
    Blocking waiting for file lock on package cache
    Checking core v0.0.0 (C:\Users\cbeuw\Documents\Rust\rust\library\core)
    Checking smallvec v1.4.2
    Checking rustc_graphviz v0.0.0 (C:\Users\cbeuw\Documents\Rust\rust\compiler\rustc_graphviz)
    Checking rustc-ap-rustc_graphviz v705.0.0
   Compiling clippy-mini-macro-test v0.2.0 (C:\Users\cbeuw\Documents\Rust\rust\src\tools\clippy\mini-macro)
    Checking rustc_error_codes v0.0.0 (C:\Users\cbeuw\Documents\Rust\rust\compiler\rustc_error_codes)
    Checking rustc_tools_util v0.2.0 (C:\Users\cbeuw\Documents\Rust\rust\src\tools\clippy\rustc_tools_util)
   Compiling proc-macro2 v1.0.26
error: could not compile `clippy-mini-macro-test`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

[ERROR project_model::workspace] cyclic deps: rustc_std_workspace_core(CrateId(1157)) -> core(CrateId(195)

Whereas the earlier version 0.2.546 can check the repo fine without any error output.

I have overriden the checkOnSave command if this is of any significance:

    "rust-analyzer.checkOnSave.overrideCommand": [
        "./x.py",
        "check",
        "--json-output"
    ],
@cbeuw
Copy link
Author

cbeuw commented Apr 18, 2021

Nvm the issue still exists with 0.2.546. Somehow it was fine earlier. Maybe to do with inderministic pipelining?

@cbeuw cbeuw closed this as completed Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant