Make BindgenOptions private #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon. |
nox
reviewed
Sep 18, 2017
src/lib.rs
Outdated
| #[derive(Debug)] | ||
| #[deprecated] | ||
| pub struct BindgenOptions { | ||
| pub(crate) struct BindgenOptions { |
There was a problem hiding this comment.
It's in the root, so it can just be private.
There was a problem hiding this comment.
Makes sense, thanks!
pepyakin
force-pushed
the
hide-bindgen-options
branch
from
4e02320
to
89c3315
Compare
pepyakin
force-pushed
the
hide-bindgen-options
branch
from
89c3315
to
e8e6f37
Compare
|
Looks great, thanks @pepyakin! @bors-servo r+ |
|
📌 Commit e8e6f37 has been approved by |
|
☀️ Test successful - status-travis |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958
r? @fitzgen