Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc chapter #104

Closed
japaric opened this issue Jun 17, 2014 · 10 comments
Closed

Arc chapter #104

japaric opened this issue Jun 17, 2014 · 10 comments

Comments

@japaric
Copy link
Member

japaric commented Jun 17, 2014

Add information about Arc to https://rustbyexample.com/std.html

@japaric japaric mentioned this issue Jun 17, 2014
52 tasks
@brson brson added D-easy and removed C-taken labels Jun 27, 2016
@rust-lang rust-lang deleted a comment from brson Sep 15, 2017
@steveklabnik
Copy link
Member

(meta: deleted a comment and moved it into the description)

I'm happy to mentor anyone who wants to fix this issue!

@justohdezromera
Copy link

(meta: deleted a comment and moved it into the description)

I'm happy to mentor anyone who wants to fix this issue!

Hi @steveklabnik, I would like to work on this. Would you be available for mentoring?

@steveklabnik
Copy link
Member

Hey @justohdezromera !

So, yes and no. That is, I can help mechanically, but I am not sure if a chapter on arc fits into the current structure or not, nor where. Maybe @marioidival has opinions.

@justohdezromera
Copy link

In my opinion, I would find it coherent since I see that Arc is a struct type. Even it is a Thread related type, still a type. Furthermore, it could be placed just after the Rc chapter, since they are kind of counter-elements.

@steveklabnik
Copy link
Member

Ah yes, if there's already stuff about RC, honestly, adding arc to it would probably make the most sense.

@justohdezromera
Copy link

justohdezromera commented Aug 1, 2020

Hi @steveklabnik, I do have this repo modified to solve this issue but I am not aware of how to upload it here, I mean mechanically. I am not sure if I have to make a push to the master branch or how it is really done, may I have some clarification here, please?

edit: While I was pressing the Comment button I saw down there the link to the contributing guidelines, so there I finally saw how it is done :). I will make a pull request for the master branch them. The changes I made were:

  • Edit the summary to add the Arc chapter.
  • Create and edit the Arc chapter inside the std library chapter.
  • Edit Rc chapter to reference Arc as an implementation in std::sync.

@steveklabnik
Copy link
Member

Sure thing!

So, on GitHub, the main way that you send in updates is by sending a pull request, that is, a request to pull changes from your repository into the main repository. Here's GitHub's docs on how to start one: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests

But! I can also explain. So, ....... oh wait, you just edited your comment, so looks like you know what's going on. Give it a shot and let me know :) If you get stuck, I can help!

@justohdezromera
Copy link

I think I did the request by now, I forked the repo and updated it privately, then requested the merge to the original repo. Was that OK? :)

@steveklabnik
Copy link
Member

Looks like you got the mechanics right, yep! I don't have time to review right now, but I or someone else will get to it. Thank you!

@justohdezromera
Copy link

May be this issue can now be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants