inconsistent_struct_constructor deletes cfgs

[kpreid]

Summary

The fix for inconsistent_struct_constructor deletes fields in a struct literal that are cfged out, and deletes all the cfgs. It should preserve all cfgs, not give a suggestion in this case, or be made not MachineApplicable.

Reproducer

I tried this code:

#![warn(clippy::inconsistent_struct_constructor)]

pub struct Foo {
    a: bool,
    #[cfg(something)]
    b: bool,
    #[cfg(all())]
    c: bool,
}

impl Foo {
    pub fn new(a: bool, b: bool, c: bool) -> Self {
        Self {
            #[cfg(something)]
            b,
            #[cfg(all())]
            c,
            a,
        }
    }
}

I expected to see this happen: Suggestion of

        Self {
            a,
            #[cfg(something)]
            b,
            #[cfg(all())]
            c,
        }

or no suggestion.

Instead, this happened: Suggestion of Self { a, c }.

Version

rustc 1.77.0 (aedd173a2 2024-03-17)
binary: rustc
commit-hash: aedd173a2c086e558c2b66d3743b344f977621a7
commit-date: 2024-03-17
host: x86_64-apple-darwin
release: 1.77.0
LLVM version: 17.0.6

Also reproduces on nightly.

Additional Labels

@rustbot label +I-suggestion-causes-error