Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a build script that complains about wrong nightly versions #2716

Closed
oli-obk opened this issue May 2, 2018 · 3 comments
Closed

add a build script that complains about wrong nightly versions #2716

oli-obk opened this issue May 2, 2018 · 3 comments
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 2, 2018

Similar to what rocket has. Since we don't know what future rustc versions are OK, we just emit an error message if the rustc version is too old

@phansch
Copy link
Member

phansch commented May 3, 2018

I suppose that this is the build script, right? https://github.com/SergioBenitez/Rocket/blob/master/lib/build.rs

Oh and this works using the cargo build script feature, nice!

@oli-obk
Copy link
Contributor Author

oli-obk commented May 3, 2018

jup. we should probably read the version numbers from an extra file with include_str (instead of hardcoding in the build.rs) so we can just generate the current version number via the update_lints python script

@phansch
Copy link
Member

phansch commented May 3, 2018

Going to take a look at this now and hope to have something merge-ready by next week 👍

@phansch phansch added the C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages
Projects
None yet
Development

No branches or pull requests

2 participants