Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if we can get a rustc with debug assertions on CI #3634

Open
matthiaskrgr opened this issue Jan 5, 2019 · 6 comments
Open

check if we can get a rustc with debug assertions on CI #3634

matthiaskrgr opened this issue Jan 5, 2019 · 6 comments
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@matthiaskrgr
Copy link
Member

There have been cases recently where clippy would crash if rustc was build with debug-assertions enabled.

#3628
rust-lang/rust#57298

To earlier catch regressions it might be helpful if we could get something like a rustc master tarball that has debug assertions enabled but I'm not sure if this exists.

@matthiaskrgr matthiaskrgr added E-help-wanted Call for participation: Help is requested to fix this issue. A-infra Area: CI issues and issues that require full access for GitHub/CI labels Jan 5, 2019
@o01eg
Copy link
Contributor

o01eg commented Jan 5, 2019

What about to use Ubuntu's PPA infrastructure?

@mati865
Copy link
Contributor

mati865 commented Jan 5, 2019

I could create PPA but there is 2 GiB space quota so it could only keep 1 or 2 latest builds for LTS and latest Ubuntu release.
Additionally depending on the priority of the build it can take up to few hours to get build while rustc master provides builds very fast. We would run into issue when Ubuntu builds are blocking PRs because they are too old.

@ghost
Copy link

ghost commented Jan 5, 2019

having rustc with debug assertions can crash firefox/servo too: servo/servo#22613
so, is this one more reason to have such a rustc ready for testing stuff with? ...

@mati865
Copy link
Contributor

mati865 commented Jan 5, 2019

Maybe rust infra could provide builds with debug-assertions alongside normal builds if this is beneficial to many users.

@matthiaskrgr
Copy link
Member Author

Hmm... I tried

rustup-toolchain-install-master --alt
cargo +2fba17fc972f89fe9165fbed77d2f0ad6d3e2174-alt test

but the alt rustc did not trigger any ICE on clippy d264e40 :/

@mati865
Copy link
Contributor

mati865 commented Jan 5, 2019

Nightly builds have LLVM assertions enabled to catch bugs, nightly alt builds don't have them in order to improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

No branches or pull requests

3 participants