Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use avoid_breaking_public_api configuration in types module #7489

Closed
xFrednet opened this issue Jul 24, 2021 · 1 comment · Fixed by #7560
Closed

Use avoid_breaking_public_api configuration in types module #7489

xFrednet opened this issue Jul 24, 2021 · 1 comment · Fixed by #7560
Assignees
Labels
A-ui Area: Clippy interface, usage and configuration C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages

Comments

@xFrednet
Copy link
Member

xFrednet commented Jul 24, 2021

Clippy has a configuration value called avoid_breaking_public_api which disables lint messages suggesting changes to the public API of a crate. This configuration value should also affect lints inside the type module, as discussed in #7308 (here).

The addition of this configuration value will be a bit different as it has to be handled in the type module. I for that reason suggested doing this change for all type lints in one go after #7308 has been merged, which it has.

I plan to work on this soon, however I would also be happy to pass it up or mentor someone if they are interested. 🙃

See: #7187 for implementation examples

@rustbot rustbot added A-ui Area: Clippy interface, usage and configuration C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages labels Jul 24, 2021
@xFrednet xFrednet changed the title Consider avoid_breaking_public_api configuration in types module Use avoid_breaking_public_api configuration in types module Jul 24, 2021
@xFrednet
Copy link
Member Author

xFrednet commented Aug 2, 2021

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: Clippy interface, usage and configuration C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants