Clippy suggests an unintuitive fix

[asonix]

Summary

Clippy's suggested fix for returning 1 or 0 from an if statement is unintuitive

Reproducer

writing code like

if opt.is_some() {
    1
} else {
    0
}

leads clippy to suggest usize::from(opt.is_some()), i.e. coercing a boolean into an integer. It is not obvious to me that a boolean coerced into an integer will yield 0 for false and 1 for true. I'm not even sure why rust implements this From.

I've settled on opt.map_or(0, |_| 1) in order to avoid the lint while also still being clear about the output values.

Version

rustc 1.65.0 (897e37553 2022-11-02)
binary: rustc
commit-hash: 897e37553bba8b42751c67658967889d11ecd120
commit-date: 2022-11-02
host: x86_64-unknown-linux-gnu
release: 1.65.0
LLVM version: 15.0.0

Additional Labels

No response