Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't double-click on failure location when 'show_errors_inline' is enabled #263

Open
TheIronBorn opened this issue Mar 15, 2018 · 4 comments
Labels
A-messages Area: Build messages

Comments

@TheIronBorn
Copy link

TheIronBorn commented Mar 15, 2018

Just me or is this from the README not true?

- failed test source line (clickable)


Sublime Text Version

Sublime Text 3 (Build 3143)

Rust Enhanced Version

v2.10.0

Operating system

macOS 10.13.3

Expected behavior

A test failure occurs. I double-click on the printed file location of the test failure, Sublime scrolls to view the location.

Actual behavior

Nothing

Steps to reproduce

  1. Have show_errors_inline set to true
  2. Run a test which fails
@ehuss
Copy link

ehuss commented Mar 15, 2018

Yea, that's not terribly clear. It also doesn't always work very well.

If you have show_errors_inline set to false, then if you can double-click on the filename in the output window to jump to that file. For example, double-clicking on "tests/test_example:3:5" will jump to that file and line:

image

It looks like it is broken if show_errors_inline is true. The regex in opanel.py needs to be fixed.

You can also use the next/previous message shortcut (F4) to jump between errors (that uses a different mechanism).

Long term eventually libtest will hopefully have a JSON output with file/line information so it will be easier to detect which tests have failed. (Though I'm not sure how that should work if there is a panic deep in a stack trace.)

@TheIronBorn TheIronBorn changed the title Can't click on failure location Can't double-click on failure location Mar 15, 2018
@TheIronBorn
Copy link
Author

Confirm it works with "show_errors_inline": false

@TheIronBorn TheIronBorn changed the title Can't double-click on failure location Can't double-click on failure location when 'show_errors_inline' is enabled Mar 15, 2018
@TheIronBorn
Copy link
Author

I also can't "Next Result" to the test failure

@TheIronBorn
Copy link
Author

Using the proper Rust Enhanced rust_next_message, I am taken to the test failure.

@ehuss ehuss added the A-messages Area: Build messages label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-messages Area: Build messages
Projects
None yet
Development

No branches or pull requests

2 participants