New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first stab at adding syntax checking on save similar to GoSublime #82
first stab at adding syntax checking on save similar to GoSublime #82
Conversation
changing cargo run to cargo rustc -- -Zno-trans |
Fixed the error now, and added async so no hanging now either! |
Neat! I don't use sublime personally, so I'm not sure I want to merge. |
It would be good to hear some reviews from people who use sublime to see what they think |
@Jayflux It looks great! My only question is why do all tooltips start with a |
Its a bug, i'm working on that |
return original_pt | ||
|
||
|
||
def lol(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this was unintentionally left in?
@Aaronepower the tooltip bug if fixed, here's a preview |
@Jayflux Looking great. You should probably add a comment on the callback explaining that behaviour, and have you tested this against projects with a build script? As they typically put all the code into tokei uses a build script, so you can test it on that if you need. |
Just tested on tokei We decided this isn't really an issue and there's very little we can do about it, the plugin just silently fails |
@Aaronepower I've now added settings, so its not on by default. I've also checked it on different color schemes |
@steveklabnik could you take a look at this? |
As I said above, it seems good to me, but I also don't use sublime. I'm not actually sure who is in charge of the sublime plugin. Looking at recent PRs, it looks like @brson and myself were the last ones to merge things. He is on vacation, so I'm gonna just merge this. 👍 |
Don't want to be a spoilsport but there's already a pretty good linter here. |
HI guys
I really liked the syntax checking on save within GoSublime.
So i had a go at trying it for Rust.
Under the hood all this plugin does is call "cargo run" in the same directory the file is in, if there's any errors it will try and parse out the first line number, then return that back to sublime.
It would be nice if some sublime users could take a look at my PR and tell me what they think needs adding or their thoughts.
here is a demo
Thanks Jason