Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Improve playpen error handling #108

Merged
merged 1 commit into from Apr 11, 2015
Merged

Conversation

whipsch
Copy link
Contributor

@whipsch whipsch commented Apr 11, 2015

There was no case for handling an error returned by the playpen web application itself. This commit ensures that future mishaps like #107 are more visible to users and are more likely to get reported due to the hard error message, instead of nothing happening.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

brson added a commit that referenced this pull request Apr 11, 2015
@brson brson merged commit c50468f into rust-lang:gh-pages Apr 11, 2015
@brson
Copy link
Contributor

brson commented Apr 11, 2015

Thanks!

@whipsch whipsch deleted the fix-playpen-errors branch April 11, 2015 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants