Build site on S3 (tidy PR this time) #150
Conversation
See https://travis-ci.org/edunham/rust-www/builds/67560526 and http://www-rust-lang-org.s3-website-us-west-1.amazonaws.com/ for an example of it successfully working. That was built specifying `edunham/rust-www`, whereas the file now specifies `rust-lang/rust-www` because we want to automate builds after this PR lands.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Helps fix #148 . |
|
r? @brson, @alexcrichton |
| language: ruby | ||
| rvm: | ||
| - 2.1 | ||
| install: gem install jekyll |
There was a problem hiding this comment.
this line shouldn't need to exist, as we already have a Gemfile, and travis runs bundle install -j 3 automatically if you have one. By using the Gemfile version rather than this, we get caching for free too.
Build site on S3 (tidy PR this time)
|
Looks good. |
@alexcrichton has already enabled Travis for the repo.
I tested all this in my fork and got http://www-rust-lang-org.s3-website-us-west-1.amazonaws.com/ working. This will do the exact same thing (only change to the
.travis.ymlis specifying the repo owned by rust-lang rather than by me).This PR will not affect the behavior of the current (github pages) site at all, since it's to master.