Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix Spanish translation #684

Closed
wants to merge 1 commit into from
Closed

Fix Spanish translation #684

wants to merge 1 commit into from

Conversation

alx741
Copy link
Contributor

@alx741 alx741 commented Jan 11, 2017

Wow! I failed to create a _layouts/es/ for it and breaked the page, sorry about that! This will fix it.

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alilleybrinker
Copy link
Contributor

This is also addressed in #682, which also renames es/ to es-ES/, for consistency with the two-part language codes used elsewhere on the site.

@alx741
Copy link
Contributor Author

alx741 commented Jan 11, 2017

mmhh... In that case that should be merged first, then this PR could be rebased from there and merged as well so the _layouts/es has the Spanish translation instead of just the default English one. Edit: I guess the other way around would work as well

@brson
Copy link
Contributor

brson commented Jan 18, 2017

Looks like the other is merged and this is ready for a rebase.

@alx741
Copy link
Contributor Author

alx741 commented Jan 18, 2017

Perfect, that should do it

@alexcrichton
Copy link
Member

@alx741 it looks like the files are now located as es-ES, want to update that location instead?

(sorry for the delay!)

@alx741
Copy link
Contributor Author

alx741 commented Feb 12, 2017

Sure, Now it should be ok

<a href="/pt-BR/">Português</a>,
<a href="/ru-RU/">Русский</a>,
<a href="/vi-VN/">Tiếng việt</a>,
<a href="/zh-CN/">简体中文</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I think this is now generally in footer.html, so perhaps just the "Nuestro ..." phrase could be updated and otherwise include footer.html could stay?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants