Skip to content

Latest commit

 

History

History
104 lines (75 loc) · 6.44 KB

2023-10-10.md

File metadata and controls

104 lines (75 loc) · 6.44 KB
Raw

2023-10-10 Triage Log

A quiet week, with few regressions and improvements.

Triage done by @simulacrum. Revision range: 9998f4add08c3d09c82e00975cf3a293b30160ec..84d44dd1d8ec1e98fff94272ba4f96b2a1f044ca

Summary:

(instructions:u) mean range count
Regressions ❌
(primary)		 0.8% [0.3%, 2.9%] 47
Regressions ❌
(secondary)		 1.1% [0.2%, 4.8%] 19
Improvements ✅
(primary)		 -2.0% [-3.6%, -0.4%] 2
Improvements ✅
(secondary)		 -0.5% [-0.7%, -0.4%] 11
All ❌✅ (primary) 0.7% [-3.6%, 2.9%] 49

1 Regressions, 2 Improvements, 4 Mixed; 1 of them in rollups 68 artifact comparisons made in total

Regressions

Rollup of 7 pull requests #116492 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 0.9% [0.7%, 1.0%] 2
Regressions ❌
(secondary)		 2.3% [1.2%, 3.6%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.9% [0.7%, 1.0%] 2

This is likely due to better ability to optimize, see comment.

Improvements

Rollup of 5 pull requests #116455 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.7% [-0.9%, -0.5%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.7% [-0.9%, -0.5%] 3

Generalize small dominators optimization #116454 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.8%, -0.3%] 7
Improvements ✅
(secondary)		 -0.9% [-1.1%, -0.7%] 7
All ❌✅ (primary) -0.5% [-0.8%, -0.3%] 7

Mixed

Make subtyping explicit in MIR #115025 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 0.6% [0.4%, 0.8%] 2
Regressions ❌
(secondary)		 0.5% [0.1%, 1.1%] 17
Improvements ✅
(primary)		 -0.5% [-0.6%, -0.5%] 2
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) 0.0% [-0.6%, 0.8%] 4

Remove mir::LocalDecl::internal. #116427 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 0.6% [0.4%, 0.8%] 4
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [-0.4%, 0.8%] 5

Remove is global hack #116417 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 0.4% [0.1%, 1.4%] 22
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.7% [-0.9%, -0.2%] 7
All ❌✅ (primary) 0.4% [0.1%, 1.4%] 22

Always preserve DebugInfo in DeadStoreElimination. #116183 (Comparison Link)

(instructions:u) mean range count
Regressions ❌
(primary)		 0.7% [0.2%, 3.1%] 30
Regressions ❌
(secondary)		 1.4% [0.1%, 2.3%] 13
Improvements ✅
(primary)		 -1.1% [-3.1%, -0.2%] 4
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) 0.5% [-3.1%, 3.1%] 34