Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimized version of projection caching example #1124

Closed
Aaron1011 opened this issue Dec 19, 2021 · 2 comments · Fixed by #1153
Closed

Add minimized version of projection caching example #1124

Aaron1011 opened this issue Dec 19, 2021 · 2 comments · Fixed by #1153

Comments

@Aaron1011
Copy link
Member

In rust-lang/rust#89831 (comment), a build went from taking 3 minutes to 12 hours. Nothing in our current benchmark suite reflected this regressions (and the fix showed "This benchmark run did not return any relevant changes."). We should add a reduced version of that example which captures the enormous impact of projection cache 'completion' on certain workloads.

@Mark-Simulacrum
Copy link
Member

Do we have any example code for that case yet? I definitely agree that we should add something to this effect to the benchmark suite, whether as a real-world test case or a manufactured stress test.

@Aaron1011
Copy link
Member Author

I don't know if we have a concrete example. @nayato: Are you able to share the codebase that experienced the regression you described in rust-lang/rust#89831 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants