Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable local std? #724

Open
Mark-Simulacrum opened this issue Jul 27, 2020 · 3 comments
Open

Re-enable local std? #724

Mark-Simulacrum opened this issue Jul 27, 2020 · 3 comments

Comments

@Mark-Simulacrum
Copy link
Member

This tracks the potential revert of 048360c, which caused a 10% regression on the collection server.

Before we revert I would like to determine the cause of the regression, i.e., what difference it made that std was built on the collector rather than in Rust's CI. Ideally, that investigation will mean that we adjust Rust's CI to build a better std.

@nnethercote
Copy link
Contributor

Any progress here?

@rylev
Copy link
Member

rylev commented Jul 29, 2021

@Mark-Simulacrum what's the latest on this?

@Mark-Simulacrum
Copy link
Member Author

I don't recall doing any further investigation. I'm not sure if it's worth doing that still or if we should just close this.

I'd guess that we could try re-applying that commit ( 048360c) and see whether that gives us a performance win. If so, then exploring how we can adjust rustc mainline CI to get the same win may well be worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants