Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run abi-cafe on arm64 macOS #1512

Open
bjorn3 opened this issue Jul 13, 2024 · 0 comments · May be fixed by #1515
Open

Run abi-cafe on arm64 macOS #1512

bjorn3 opened this issue Jul 13, 2024 · 0 comments · May be fixed by #1515
Labels
A-abi Area: ABI handling A-testing Area: Testing of cg_clif itself C-enhancement Category: An issue proposing an enhancement or a PR with one. O-arm Target: ARM processors (arm, thumb and AArch64 targets) O-macos Operating system: MacOS

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jul 13, 2024

If there are no failures on arm64 macOS this would just be a matter of adding a new entry to

rustc_codegen_cranelift/.github/workflows/abi-cafe.yml

Lines 24 to 35 in 659243d

- os: ubuntu-latest
env:
TARGET_TRIPLE: x86_64-unknown-linux-gnu
- os: macos-latest
env:
TARGET_TRIPLE: x86_64-apple-darwin
- os: windows-latest
env:
TARGET_TRIPLE: x86_64-pc-windows-msvc
- os: windows-latest
env:
TARGET_TRIPLE: x86_64-pc-windows-gnu
If there are failures, they will have to be marked as busted in patches/0002-abi-cafe-Disable-broken-tests.patch.
@bjorn3 bjorn3 added C-enhancement Category: An issue proposing an enhancement or a PR with one. O-macos Operating system: MacOS A-abi Area: ABI handling O-arm Target: ARM processors (arm, thumb and AArch64 targets) A-testing Area: Testing of cg_clif itself labels Jul 13, 2024
@lqd lqd linked a pull request Jul 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-abi Area: ABI handling A-testing Area: Testing of cg_clif itself C-enhancement Category: An issue proposing an enhancement or a PR with one. O-arm Target: ARM processors (arm, thumb and AArch64 targets) O-macos Operating system: MacOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable abi-cafe tests on aarch64-apple-darwin lqd/rustc_codegen_cranelift
1 participant
@bjorn3