Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the error UI tests in a new CI job #495

Closed
antoyo opened this issue Apr 19, 2024 · 5 comments · Fixed by #524
Closed

Run the error UI tests in a new CI job #495

antoyo opened this issue Apr 19, 2024 · 5 comments · Fixed by #524
Assignees
Labels
good first issue Good for newcomers

Comments

@antoyo
Copy link
Contributor

antoyo commented Apr 19, 2024

Since some of them has an ICE: #296

We currently remove the tests that emits an error in the frontend here.
I would like to have a new test that will run those tests (and only these tests with errors) in failures.yml.

@antoyo antoyo added the good first issue Good for newcomers label Apr 19, 2024
@mubarak23
Copy link
Contributor

@antoyo can you further explain this, i will like to handle it

@lordshashank
Copy link
Contributor

@antoyo what do you want to be done here, currently failing rust test suits are ran through --test-failing-rustc here, do you want ui tests to have separate run command like --test-failing-ui-tests, and run it under separate name in failures.yaml or something else?

@antoyo
Copy link
Contributor Author

antoyo commented May 22, 2024

I edited the description to explain more.

@lordshashank
Copy link
Contributor

Got it, can work this out now, thanks

@antoyo
Copy link
Contributor Author

antoyo commented May 23, 2024

I assigned the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants