[unstable option] fn_single_line

[scampi]

Tracking issue for unstable option: fn_single_line

[dhardy]

Can this option be a little more selective please?

E.g., in my opinion, this is fine:

@@ -43,8 +97,6 @@
 }
 impl<T> AsMut<[T]> for Array64<T> {
-    fn as_mut(&mut self) -> &mut [T] {
-        &mut self.0
-    }
+    fn as_mut(&mut self) -> &mut [T] { &mut self.0 }
 }
 impl<T> Clone for Array64<T>
 where T: Copy + Default

but this is not:

@@ -64,13 +67,9 @@ fn game_host_open<R: Rng>(car: u32, choice: u32, rng: &mut R) -> u32 {
 
 // Returns the door we switch to, given our current choice and
 // the open door. There will only be one valid door.
-fn switch_door(choice: u32, open: u32) -> u32 {
-    free_doors(&[choice, open])[0]
-}
+fn switch_door(choice: u32, open: u32) -> u32 { free_doors(&[choice, open])[0] }
 
-fn free_doors(blocked: &[u32]) -> Vec<u32> {
-    (0..3).filter(|x| !blocked.contains(x)).collect()
-}
+fn free_doors(blocked: &[u32]) -> Vec<u32> { (0..3).filter(|x| !blocked.contains(x)).collect() }
 
 fn main() {
     // The estimation will be more accurate with more simulations

The inline_attribute_width option uses a line length to determine whether to allow a single option. The same thing here (excluding line indent) may provide a good option.

[yhm-amber]

Can this option be a little more selective please?

E.g., in my opinion, this is fine:

@@ -43,8 +97,6 @@
 }
 impl<T> AsMut<[T]> for Array64<T> {
-    fn as_mut(&mut self) -> &mut [T] {
-        &mut self.0
-    }
+    fn as_mut(&mut self) -> &mut [T] { &mut self.0 }
 }
 impl<T> Clone for Array64<T>
 where T: Copy + Default

but this is not:

@@ -64,13 +67,9 @@ fn game_host_open<R: Rng>(car: u32, choice: u32, rng: &mut R) -> u32 {
 
 // Returns the door we switch to, given our current choice and
 // the open door. There will only be one valid door.
-fn switch_door(choice: u32, open: u32) -> u32 {
-    free_doors(&[choice, open])[0]
-}
+fn switch_door(choice: u32, open: u32) -> u32 { free_doors(&[choice, open])[0] }
 
-fn free_doors(blocked: &[u32]) -> Vec<u32> {
-    (0..3).filter(|x| !blocked.contains(x)).collect()
-}
+fn free_doors(blocked: &[u32]) -> Vec<u32> { (0..3).filter(|x| !blocked.contains(x)).collect() }
 
 fn main() {
     // The estimation will be more accurate with more simulations

The inline_attribute_width option uses a line length to determine whether to allow a single option. The same thing here (excluding line indent) may provide a good option.

---

How about this :

fn free_doors(blocked: &[u32]) -> Vec<u32> 
{ (0..3).filter(|x| !blocked.contains(x)).collect() }

when brace_style = "AlwaysNextLine" ?

Almost type on a line and value on next line ...

And I do think this is better :

fn free_doors(blocked: &[u32]) -> Vec<u32> 
{
    (0..3)
        .filter(|x| !blocked.contains(x))
        .collect()
}

even if there is a fn_single_line = true option. This option is valuable only when a define is short enough.