Remove empty directories after component uninstall #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inejge thank you! Unfortunately it's the end of the day here and I'm tired. I'll try to review over the weekend. The situation where the directory can't be removed is theoretical. The installation code is intended to be used not just in rustup but for Rust packages anywhere (e.g. the installers on the main website today are the same installation format and they install to the system). I don't feel too strongly about it. |
* Fix whitespace (no tabs) * Short-circuit the iterator on non-empty dir * Avoid repetition in the part loop
|
Ah, OK. The code should then be usable as is. I've pushed another commit with fixes for a couple of nits I've noticed in the meantime. |
|
Thanks @inejge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #596. I've placed the test in tests/cli-v2.rs,
remove_target; there's an almost identical one, with the same name, in tests/cli-rustup.rs, which I haven't modified.Edit: the code does the removal pass unconditionally, as opposed to the suggestion in the issue; however, I don't see how the situation where rustup is allowed to remove the component's files, but not directories, could arise. What am I overlooking?