Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing a major.minor channel includes documentation even when profile is minimal #2593

Closed
shepmaster opened this issue Dec 2, 2020 · 4 comments
Labels

Comments

@shepmaster
Copy link
Member

Problem

Since I have set my profile to minimal, I expect that rust-docs will not be installed, but it is.

Steps

% rustup set profile minimal
info: profile set to 'minimal'

% rustup toolchain install 1.30
info: syncing channel updates for '1.30-x86_64-apple-darwin'
info: latest update on 2018-11-08, rust version 1.30.1 (1433507eb 2018-11-07)
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'

Notes

Output of rustup --version:

% rustup --version
rustup 1.23.1 (3df2264a9 2020-11-30)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.48.0 (7eac88abb 2020-11-16)`

Output of rustup show:

% rustup show
Default host: x86_64-apple-darwin
rustup home:  /Users/shep/.rustup

installed toolchains
--------------------

stable-x86_64-apple-darwin
beta-x86_64-apple-darwin
nightly-2020-11-14-x86_64-apple-darwin
nightly-x86_64-apple-darwin (default)
1.30-x86_64-apple-darwin
1.40-x86_64-apple-darwin

installed targets for active toolchain
--------------------------------------

thumbv6m-none-eabi
wasm32-unknown-unknown
x86_64-apple-darwin

active toolchain
----------------

stable-x86_64-apple-darwin (directory override for '/private/tmp')
rustc 1.48.0 (7eac88abb 2020-11-16)
@shepmaster shepmaster added the bug label Dec 2, 2020
@kinnison
Copy link
Contributor

kinnison commented Dec 2, 2020

Does this happen if you install a MAJOR.MINOR where the toolchain has profiles in its channel manifest? Rust 1.33 was the first version to include profiles in the channel manifest. Before then there was no indication to rustup what each profile might mean, and in the absence of guidance from the channel, rustup defaults to what would have been installed at the time, which includes rust-docs.

@shepmaster
Copy link
Member Author

Ahh, profiles are dictated by the channels, not by rustup? TIL.

% rustup install 1.33
info: syncing channel updates for '1.33-x86_64-apple-darwin'
info: latest update on 2019-02-28, rust version 1.33.0 (2aa4c46cf 2019-02-28)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'

@shepmaster
Copy link
Member Author

Is there another rustup mechanism to specify "no, I really never want docs by default"?

@kinnison
Copy link
Contributor

kinnison commented Dec 2, 2020

Not currently, no. If you wanted to propose something then I'd be willing to entertain options :D In general changes to rustup look forwards, but I understand your need to deal with older toolchains :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants