Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth support #34

Closed
Wodann opened this issue Jun 2, 2019 · 4 comments
Closed

Bluetooth support #34

Wodann opened this issue Jun 2, 2019 · 4 comments

Comments

@Wodann
Copy link

Wodann commented Jun 2, 2019

I have been working on a cross-platform Bluetooth implementation, and have my own cross-platform Socket implementation that is very similar to yours. To reduce duplicity, I'd like to add Bluetooth support to your repository, and use it as a dependency.

@Wodann
Copy link
Author

Wodann commented Jun 2, 2019

@alexcrichton If I'd create a pull request that implements Bluetooth support, would you be willing to add it to your repository, or would you rather keep it as a net-only socket repository?

@alexcrichton
Copy link
Member

If it's small enough and pretty cross platform, makes sense to me! If it's very platform specific though and/or a pretty big extension, it may be best as a separate crate.

@Thomasdezeeuw
Copy link
Collaborator

@Wodann do you still want to merge this with socket2? Or do you think it's best to continue living in its own crate?

@Wodann
Copy link
Author

Wodann commented Dec 23, 2020

I've honestly not had time to finish the conversion, since I originally started on it. As such, feel free to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants