Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant or constant functions #64

Closed
Thomasdezeeuw opened this issue Mar 31, 2020 · 0 comments · Fixed by #69
Closed

Constant or constant functions #64

Thomasdezeeuw opened this issue Mar 31, 2020 · 0 comments · Fixed by #69

Comments

@Thomasdezeeuw
Copy link
Collaborator

Most types have function constructors, such as Domain::ipv4, should we make this functions const functions? Or alternatively make them associated constants?

impl Domain {
    /// Domain for IPv4 communication, corresponding to `AF_INET`.
    pub fn ipv4() -> Domain {
        Domain(sys::AF_INET)
    }

    /// Domain for IPv4 communication, corresponding to `AF_INET`.
    pub const IPV4: Domain = Domain(sys::AF_INET);
}

Personally I feel like associated constants would be more appropriate, as there constants wrapped in a type. But I don't feel strongly either way.

/cc @stjepang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant