Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish STACK WIN unwinding implementation #167

Closed
Gankra opened this issue May 13, 2021 · 1 comment
Closed

Finish STACK WIN unwinding implementation #167

Gankra opened this issue May 13, 2021 · 1 comment

Comments

@Gankra
Copy link
Collaborator

Gankra commented May 13, 2021

(#26 is too molithic, breaking it up into more manageable tasks.)

Once #161 lands there will be a good chunk of this already implemented in breakpad-symbols/src/sym_file/walker.rs, but extra work is needed. STACK WIN is specifically for unwinding on x86 windows (x64 uses STACK CFI). It's still 20% of firefox's install base so important to get this working right.

Right now I think the problems are just that we're missing all the little heuristics in breakpad that scan around the stack to compensate for alignment and sloppy debuginfo.
@Gankra Gankra mentioned this issue May 13, 2021
Closed
22 tasks
@Gankra
Copy link
Collaborator Author

Gankra commented Oct 16, 2021

Done!

@Gankra Gankra closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gankra