Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we ndarray 0.15 ready yet? #124

Closed
11 tasks done
relf opened this issue Apr 22, 2021 · 11 comments
Closed
11 tasks done

Are we ndarray 0.15 ready yet? #124

relf opened this issue Apr 22, 2021 · 11 comments
Labels
infrastructure General tasks effecting all implementations

Comments

@relf
Copy link
Member

relf commented Apr 22, 2021

I open this issue to keep track of stuff required to bump to ndarray 0.15. From #110 we get the following list:

  • approx = 0.4
  • argmin = 0.4.6
  • ndarray-csv = 0.5.1
  • ndarray-linalg = 0.14.0
  • ndarray-npy = 0.8
  • ndarray-rand = 0.14
  • ndarray-stats = 0.5
  • num-traits = 0.2
  • rand = 0.8
  • rand-isaac = 0.3
  • sprs
@quietlychris
Copy link
Member

I just submitted a pull request to ndarray-csv updating it to use 0.15, and will add an update if it gets merged/a new version is posted to crates.io

@quietlychris
Copy link
Member

@relf I believe that we should be all set with ndarray-csv now--0.15 should be supported with ndarray-csv = "0.5.1"

@YuhanLiin
Copy link
Collaborator

Are we waiting for argmin, ndarray-linalg, and sprs to include ndarray 0.15 in their dependencies before bumping?

@relf
Copy link
Member Author

relf commented Jun 22, 2021

Well... I guess it was the plan, thinking that linfa's dependencies would upgrade rapidly. Do you suggest we could bump some of linfa's subcrates?

@YuhanLiin
Copy link
Collaborator

IMO it should be all or nothing. Unless we really need a feature in one of the newer versions I want to make sure we don't have two instances of ndarray in our dependency tree. I'm in favour of waiting on the remaining dependencies to update to ndarray 0.15.

@relf
Copy link
Member Author

relf commented Jun 22, 2021

Yep, we agree. Btw it seems dificult to mix different versions of ndarray anyway (when it occurs by mistake it ends up with compilation errors).

@bytesnake
Copy link
Member

both sprs and ndarray-linalg are already using ndarray = 0.15 in their git tree, but they are not yet published to crates.io. I also created an issue at argmin side argmin-rs/argmin#123

@relf
Copy link
Member Author

relf commented Jul 19, 2021

ndarray-linalg and argmin on ndarray = 0.15 are published, one to go...

@bytesnake bytesnake added the infrastructure General tasks effecting all implementations label Jul 22, 2021
@bytesnake
Copy link
Member

I would like to update all dependencies to ndarray = 0.15 before publishing a new linfa version

@mulimoen
Copy link

sprs 0.11.0 was published right now, and uses ndarray = 1.15

@relf
Copy link
Member Author

relf commented Aug 1, 2021

Closed by #156

@relf relf closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure General tasks effecting all implementations
Projects
None yet
Development

No branches or pull requests

5 participants