-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling datasets with multiple targets? #84
Comments
Hey, The targets matrix can be 1, 2 or three dimensional in three different cases:
here is L the number of labels, M the number of targets and N the number of points. Because pub type Dataset<D, T> = DatasetBase<ArrayBase<OwnedRepr<D>, Ix2>, ArrayBase<OwnedRepr<T>, Ix3>>; and then update the whole machinery in |
I added a point to #70 for this feature |
Ok thanks. I was too conservative and not aware of the third case (do you have an example in mind?)
Does it mean you plan to work on that in the coming weeks? |
yes playing around with this right now, because it is a prerequisite for #66 I will open a PR once I have something useful |
work started in #88, I think the basic mechanism is in place and I will finish the PR in the next days |
finally merged #88, can you give feedback whether everything works as expected? |
Ok, I will. I will resume my work on linnerud dataset. FYI, I am working on a port of PlsRegression which is tested against that dataset. If it goes well, maybe it could land in linfa? Where? A new member |
sounds good, we should add CCA at a later point as well. If you want to implement the SVD version, you can use |
A suggestion: now that we have several targets, we could have |
I would like to add the linnerud dataset to linfa-dataset but I've noticed that currently targets are only handled as a one-dimensional array. Should we introduce something like:
or is there a better way?
The text was updated successfully, but these errors were encountered: