Skip to content
This repository has been archived by the owner on Jul 3, 2020. It is now read-only.

cargo-apk install builds debug build #236

Closed
philip-alldredge opened this issue Sep 1, 2019 · 3 comments · Fixed by #237
Closed

cargo-apk install builds debug build #236

philip-alldredge opened this issue Sep 1, 2019 · 3 comments · Fixed by #237

Comments

@philip-alldredge
Copy link
Contributor

philip-alldredge commented Sep 1, 2019

Additionally, the install command needs to support the release flag.

@philip-alldredge
Copy link
Contributor Author

@mb64 I can take a look at this. Adding here for tracking. This was observed when tracking down recent issues but this is not the cause of the issues.

@philip-alldredge philip-alldredge changed the title Fix release mode support in cargo-apk Support --release flag for install command in cargo-apk Sep 1, 2019
@philip-alldredge
Copy link
Contributor Author

After further investigation, it turns out that the release builds are working as expected. I have updated the issue accordingly. The only thing that needs to be fixed for this issue is the support for the release flag in the install command.

@philip-alldredge philip-alldredge changed the title Support --release flag for install command in cargo-apk cargo-apk install builds debug build Sep 1, 2019
@philip-alldredge
Copy link
Contributor Author

philip-alldredge commented Sep 1, 2019

Another option would be to not support the --release flag but to rather build the release version by default. This would be more in line with how cargo install works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant