Use libui-ng instead of dormant libui #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I seems the AppVeyor build is broken for reasons unrelated to this PR) |
|
I'm satisfied that this works and have it building and successfully testing in Nix as well, so I'm going to accept it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because libui didn't show any activity for years, i propose to use the active libui-ng instead.
No API functions were remove (only added) and it still compiles wonderfully. I only had to:
I successfully built and then ran a test application on Debian 11 and on Windows 10. I encountered no issues that i could attribute to the updated library.