Removed 'regex' and 'lazy_static' dependency #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
insert_dual_endings()
pulls in two dependencies (including a full regex engine) for a task that doesn't really justify their use. As a friend of independent applications and libraries I'd welcome if those two crates can be removed.Of course the new algorithm passes the unit tests. If you are wondering about the
len+ 2
inString::with_capacity()
, I though i'd leave room for two inserts before causing an allocation.