Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'regex' and 'lazy_static' dependency #122

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Removed 'regex' and 'lazy_static' dependency #122

merged 2 commits into from
Jan 13, 2023

Conversation

nptr
Copy link
Contributor

@nptr nptr commented Dec 14, 2022

I noticed that insert_dual_endings() pulls in two dependencies (including a full regex engine) for a task that doesn't really justify their use. As a friend of independent applications and libraries I'd welcome if those two crates can be removed.

Of course the new algorithm passes the unit tests. If you are wondering about the len+ 2 in String::with_capacity(), I though i'd leave room for two inserts before causing an allocation.

@NoraCodes
Copy link
Collaborator

Clearly a good change; I have a quick style change in https://github.com/nptr/libui-rs/pull/1

@NoraCodes NoraCodes merged commit 3496903 into rust-native-ui:trunk Jan 13, 2023
@nptr nptr deleted the feature/deps branch January 20, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants