-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a canvas example #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks a lot for remembering, @barzamin, much appreciated! Will try it right away! 😄 |
issue on win systems:
|
NoraCodes
reviewed
Jan 30, 2019
per @NoraCodes' suggestion; cf 27312b4
barzamin
force-pushed
the
canvas-example
branch
from
January 31, 2019 23:56
df9fbf8
to
94d5d1a
Compare
NoraCodes
previously requested changes
Feb 1, 2019
Sure, I can totally do that.
…On Thu, Jan 31, 2019 at 9:04 PM Leonora ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In iui/src/draw/path.rs
<#58 (comment)>
:
> @@ -14,22 +12,37 @@ impl Drop for Path {
}
}
+#[derive(Clone, Copy, PartialEq)]
+pub enum FillMode {
Could you add a doc comment onto here? Aside from this the PR looks good,
thanks so much!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATM34Q7qR3dulUxiLxqWeSWWQAVEnU78ks5vI67BgaJpZM4Z877x>
.
|
cc @NoraCodes |
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24. the example just renders the following:
/cc @pomettini (you wanted to know about this ~12 days ago. sorry! hopefully this is a good reference)