Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AxisDescription a non-tuple-struct #914

Closed
jturner314 opened this issue Feb 8, 2021 · 1 comment · Fixed by #915
Closed

Make AxisDescription a non-tuple-struct #914

jturner314 opened this issue Feb 8, 2021 · 1 comment · Fixed by #915

Comments

@jturner314
Copy link
Member

I'm curious why AxisDescription is a tuple struct. Since the fields are pub anyway, I think it would be more convenient to change the definition to this

pub struct AxisDescription {
    pub axis: Axis,
    pub len: usize,
    pub stride: isize,
}

and remove the .axis(), .len(), and .stride() methods.

@bluss
Copy link
Member

bluss commented Feb 8, 2021

Sure and the methods can be deprecated first (there is no field-method name conflict)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants