Add consistent way of initializing custom event kinds

[ok300]

Describe the enhancement

It's possible to construct event kinds that make them incompatible with (i.e. not == to) the json deserialized version of themselves.

The enhancement would be to only expose valid ways of constructing event kinds, such that this is not an issue anymore.

Use case

For example, for a custom kind 20100, which is in the ephemeral range:

// Will NOT work (false)
if let received_event.kind == Kind::Custom(20100) { }

// Will work (true)
if let received_event.kind == Kind::Ephemeral(20100) { }

// Will work (true)
// Looks like the most appropriate way
if let received_event.kind == Kind::from(20100) { }

Additional context

The only way I can think of is to enforce kinds to only be constructed via Kind::from(u64), although not sure how to do that.

[yukibtc]

Maybe the best way is to impl Eq and PartialEq manually checking if the u64 kind number is equal.
In this way Kind::Custom(20100) will be equal to Kind::Ephemeral(20100).
What do you think?

[yukibtc]

Something like:

impl PartialEq<Kind> for Kind {
    fn eq(&self, other: &Kind) -> bool {
        self.as_u64() == other.as_u64()
    }
}

[ok300]

Sounds promising.

[yukibtc]

Now I have the doubt to have misunderstood what you mean.
Have I?

I don't think that can be enforced the use of Kind::from(...).

Using the solution that I applied, if someone used Kind::Custom instead Kind::Ephemeral everything works (I added ephemeral kind not long ago). In this way it's backwards compatible.

[ok300]

Tested the new version, works! Thanks.

You're right, your idea with PartialEq is even better than enforcing Kind::from(...). Especially cause it's backwards compatible.