Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid cloning #110

Open
konsumlamm opened this issue Sep 15, 2022 · 0 comments
Open

Try to avoid cloning #110

konsumlamm opened this issue Sep 15, 2022 · 0 comments

Comments

@konsumlamm
Copy link

Currently, the arithmetic operations do a lot of clones. However, this is quite inefficient when using types with non-trivial Clone impls, such as BigInt in BigRational. We could instead do the operations on references, to avoid the cloning. However, since the impls use the Integer trait, which only supports arithmetic operations on owned values, it seems this would need new trait bounds (like NumRef or RefNum).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant