Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.2.7 breaks nostd builds #115

Closed
mullr opened this issue May 21, 2019 · 5 comments
Closed

Version 0.2.7 breaks nostd builds #115

mullr opened this issue May 21, 2019 · 5 comments
Labels

Comments

@mullr
Copy link

mullr commented May 21, 2019

With 0.2.7, we're now getting:

error[E0407]: method `to_u128` is not a member of trait `ToPrimitive`
  --> /home/mullr/.cargo/registry/src/github.com-1ecc6299db9ec823/num-complex-0.2.1/src/cast.rs:7:9
   |
7  | /         fn $to(&self) -> Option<$ty> {
8  | |             if self.im.is_zero() { self.re.$to() } else { None }
9  | |         }
   | |_________^ not a member of trait `ToPrimitive`
...
26 |       impl_to_primitive!(u128, to_u128);
   |       ---------------------------------- in this macro invocation

.. and a boatload of other related errors.

It seems likely that this is related to the autocfg change made in this release.

@cuviper
Copy link
Member

cuviper commented May 21, 2019

In theory, autocfg should have the exact same code that the manual build script did before, but it's possible I made a mistake in extracting that. Can you share cargo build -v output? and rustc -Vv?

@cuviper
Copy link
Member

cuviper commented May 21, 2019

Ugh, I see it. I tried to be smarter in autocfg by probing the given TARGET, but this doesn't work for no-std targets since I don't have #![no_std] in there.

@cuviper
Copy link
Member

cuviper commented May 22, 2019

This should be fixed by autocfg 0.1.3.

I will also increase the dependency here to make sure it sticks.

@cuviper
Copy link
Member

cuviper commented May 22, 2019

I had to yank that, because it broke CI for rust itself! Not sure why, but I'll investigate more tomorrow...

@cuviper
Copy link
Member

cuviper commented May 22, 2019

OK, we should be good again. 🤞

  • autocfg 0.1.4
  • num-integer 0.1.41
  • num-iter 0.1.39
  • num-traits 0.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants