Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CI on macos-latest #11

Closed
Coloquinte opened this issue Dec 31, 2023 · 7 comments
Closed

Build CI on macos-latest #11

Coloquinte opened this issue Dec 31, 2023 · 7 comments

Comments

@Coloquinte
Copy link
Contributor

Coloquinte commented Dec 31, 2023

Highs doesn't build using Github CI on macos-latest (see complete log).

The error is ld: library not found for -lomp, which seems related to this stackoverflow thread, where the proposed solution is to provide the full path for libomp.dynlib.

I have no idea how to make this work transparently when installing the crate, but it would be nice to have.

@lovasoa
Copy link
Contributor

lovasoa commented Dec 31, 2023

Yes, that would be nice to have indeed! Can you make a pull request?

@jajhall
Copy link
Collaborator

jajhall commented Jan 1, 2024

HiGHS doesn't need OpenMP - and hasn't for 2-3 years

@lovasoa
Copy link
Contributor

lovasoa commented Jan 1, 2024

Wow, then we should probably update https://github.com/rust-or/highs-sys/blob/master/build.rs

@jajhall , could you have a look and check whether there are other things we should update there ?

@Coloquinte
Copy link
Contributor Author

So if we don't need to build with OpenMP at all maybe we can just remove the cargo:rustc-link-lib=dylib=omp option from the highs-sys crate.

At the moment my workaround to build is the same as for highs-sys, using brew link --force libomp

@jajhall
Copy link
Collaborator

jajhall commented Jan 1, 2024

Wow, then we should probably update https://github.com/rust-or/highs-sys/blob/master/build.rs

@jajhall , could you have a look and check whether there are other things we should update there ?

Could you have a quick look through this please, @galabovaa?

@Coloquinte
Copy link
Contributor Author

Trying this right now

@Coloquinte
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants