Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likely possible to revert #168 in the next days #171

Closed
jamesmunns opened this issue May 21, 2021 · 1 comment
Closed

Likely possible to revert #168 in the next days #171

jamesmunns opened this issue May 21, 2021 · 1 comment

Comments

@jamesmunns
Copy link

Hey! We ran into the same root issue re: gc-sections fixed by #168, I wanted to highlight this upstream regression will likely be fixed by rust-lang/rust#85531, and you may decide to revert your hotfix.

It doesn't seem that passing --gc-sections twice causes problems (at least with rust-lld), so feel free to close this if you'd like to keep it, but I wanted to make sure you were in the loop.

@phil-opp
Copy link
Member

Great, thanks a lot for letting me know!

I think we'll probably keep the extra --gc-sections arg for now to ensure that people have a working crate even if they're using one of nightlies released between rust-lang/rust#85274 and rust-lang/rust#85531. In the long term, I'm happy to remove the extra argument again, but probably only on the current main branch (cc #170), not on the v0.9 hotfix. (This assumes that passing --gc-sections twice really doesn't cause any problems. If it does, we will of course do the revert.)

As a side note, I planned to update my blog_os project with a manual --gc-sections arg too in order to prevent binary bloat. It's good to know that I no longer have to do that after rust-lang/rust#85531. So thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants