You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! We ran into the same root issue re: gc-sections fixed by #168, I wanted to highlight this upstream regression will likely be fixed by rust-lang/rust#85531, and you may decide to revert your hotfix.
It doesn't seem that passing --gc-sections twice causes problems (at least with rust-lld), so feel free to close this if you'd like to keep it, but I wanted to make sure you were in the loop.
The text was updated successfully, but these errors were encountered:
I think we'll probably keep the extra --gc-sections arg for now to ensure that people have a working crate even if they're using one of nightlies released between rust-lang/rust#85274 and rust-lang/rust#85531. In the long term, I'm happy to remove the extra argument again, but probably only on the current main branch (cc #170), not on the v0.9 hotfix. (This assumes that passing --gc-sections twice really doesn't cause any problems. If it does, we will of course do the revert.)
As a side note, I planned to update my blog_os project with a manual --gc-sections arg too in order to prevent binary bloat. It's good to know that I no longer have to do that after rust-lang/rust#85531. So thanks again!
Hey! We ran into the same root issue re: gc-sections fixed by #168, I wanted to highlight this upstream regression will likely be fixed by rust-lang/rust#85531, and you may decide to revert your hotfix.
It doesn't seem that passing
--gc-sections
twice causes problems (at least with rust-lld), so feel free to close this if you'd like to keep it, but I wanted to make sure you were in the loop.The text was updated successfully, but these errors were encountered: