Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-xbuild doesn't build with older nightlies #106

Closed
vamanea opened this issue Aug 9, 2022 · 2 comments
Closed

cargo-xbuild doesn't build with older nightlies #106

vamanea opened this issue Aug 9, 2022 · 2 comments

Comments

@vamanea
Copy link

vamanea commented Aug 9, 2022

My project uses rust nightly 2021-03-23 and since some time I can't build cargo-xbuild anymore, on account of this error:

error[E0658]: use of unstable library feature 'btree_retain'
   --> /home/xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.83/src/map.rs:286:18
    |
286 |         self.map.retain(f);
    |                  ^^^^^^
    |
    = note: see issue #79025 <https://github.com/rust-lang/rust/issues/79025> for more information
    = help: add `#![feature(btree_retain)]` to the crate attributes to enable

With older serde_json(1.0.59) it builds fine.

The linked issue was fixed in 2021 Apr 14 nightlies, so updating the toolchain to that fixed my issue. The other solution is to request a specific version of serde_json in Cargo.toml.

I'm not sure which is the better fix, but I think at least updating the README to indicate the latest supported toolchain is needed.

@phil-opp
Copy link
Member

phil-opp commented Aug 9, 2022

Why do you need to install cargo-xbuild using the pinned nightly? Installing it through cargo +stable install cargo-xbuild should work in your case.

@vamanea
Copy link
Author

vamanea commented Aug 10, 2022

Right, that didn't occur to me, no idea why. Sorry for the noise.

@vamanea vamanea closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants