Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CancelAllBackgroundWork #427

Closed
ailisp opened this issue May 8, 2020 · 1 comment · Fixed by #459
Closed

Expose CancelAllBackgroundWork #427

ailisp opened this issue May 8, 2020 · 1 comment · Fixed by #459

Comments

@ailisp
Copy link

ailisp commented May 8, 2020

It's mentioned in rocksdb wiki to speed up time to waiting:

Q: Is it safe to close RocksDB while another thread is issuing read, write or manual compaction requests?
A: No. The users of RocksDB need to make sure all functions have finished before they close RocksDB. You can speed up the waiting by calling CancelAllBackgroundWork().

It'd be great to have it exposed in rust-rocksdb
@stanislav-tkach
Copy link
Member

It is definitely a good idea, but currently this function isn't exposed in the C API. I have made a pull request (facebook/rocksdb#6832), but it will take some time for it to be merged and a new version to be released.

@stanislav-tkach stanislav-tkach mentioned this issue Aug 28, 2020
Merged
@ryoqun ryoqun mentioned this issue May 23, 2021
Merged
@benesch benesch mentioned this issue Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DB::cancel_all_background_work method stanislav-tkach/rust-rocksdb
2 participants
@stanislav-tkach @ailisp