Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long initial compilation time #11

Closed
Shnatsel opened this issue Aug 1, 2020 · 1 comment
Closed

Long initial compilation time #11

Shnatsel opened this issue Aug 1, 2020 · 1 comment
Labels
fixed by upstreaming Will no longer be a problem if `auditable` is upstreamed into Cargo

Comments

@Shnatsel
Copy link
Member

Shnatsel commented Aug 1, 2020

auditable crate currently adds ~30 seconds to compilation time due to the dependencies on syn and serde.

Since serde-json is what Cargo itself uses, we have to stick to it for this to be a reasonably faithful implementation of the Cargo RFC. This issue is going to disappear once this is functionality is upstreamed into Cargo.
@Shnatsel Shnatsel added the fixed by upstreaming Will no longer be a problem if `auditable` is upstreamed into Cargo label Aug 1, 2020
@Shnatsel Shnatsel changed the title Very long compilation time Long compilation time Aug 1, 2020
@Shnatsel Shnatsel changed the title Long compilation time Long initial compilation time Aug 2, 2020
@Nemo157 Nemo157 mentioned this issue Dec 22, 2021
Closed
@Shnatsel
Copy link
Member Author

External injection via cargo auditable is now the default, and it avoids this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed by upstreaming Will no longer be a problem if `auditable` is upstreamed into Cargo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shnatsel