ISSUE-16 - Remove use of cargo::core: #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcconnell26
force-pushed
the
ISSUE-16-RemoveUseOfPackageSet
branch
from
3044f48
to
b3c6000
Compare
* Replace usage of cargo core dependency kind * Remove use of package set Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
jmcconnell26
force-pushed
the
ISSUE-16-RemoveUseOfPackageSet
branch
from
b3c6000
to
ccbc249
Compare
anderejd
reviewed
Nov 29, 2020
| .unwrap() | ||
| .push(dependency.clone()); | ||
| } | ||
|
|
||
| dependency_type_nodes | ||
| } | ||
|
|
||
| // cargo_metadata::DependencyKind doesn't implement Eq or Hash, and so can't |
There was a problem hiding this comment.
Make an upstream PR or issue, if you have the time.
There was a problem hiding this comment.
Sounds good! Have landed oli-obk/cargo_metadata#148 to resolve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: joshmc josh-mcc@tiscali.co.uk