Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Create Dockerfile: #148

Merged
merged 1 commit into from Nov 29, 2020

Conversation

jmcconnell26
Copy link
Contributor

  • Use cargo chef to reduce docker build times locally
  • Add .dockerignore

Signed-off-by: joshmc josh-mcc@tiscali.co.uk

* Use cargo chef to reduce docker build times locally
* Add .dockerignore

Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
@anderejd
Copy link
Contributor

Seems useful, let me look closer at cargo chef before merging.

@jmcconnell26
Copy link
Contributor Author

Sounds good! I found it extremely useful when developing some of my own projects, it does a great job of reducing build times for docker images.

@anderejd
Copy link
Contributor

cargo chef seems like a nice improvement, let's merge this!

Related upstream issue in cargo: rust-lang/cargo#2644

@anderejd anderejd merged commit d520b70 into geiger-rs:master Nov 29, 2020
@jmcconnell26 jmcconnell26 deleted the NOISSUE-CreateDockerfile branch November 29, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants