Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious failure with 'test_massive_task_creation' test #66

Closed
frewsxcv opened this issue Jul 8, 2017 · 2 comments
Closed

Spurious failure with 'test_massive_task_creation' test #66

frewsxcv opened this issue Jul 8, 2017 · 2 comments

Comments

@frewsxcv
Copy link
Collaborator

frewsxcv commented Jul 8, 2017

https://github.com/frewsxcv/rust-threadpool/blob/f8b13ee8a00386e63d9d430a5f9612bb51fd8b93/lib.rs#L553

example of failure: https://travis-ci.org/frewsxcv/rust-threadpool/jobs/251542770 via #64

---- test::test_massive_task_creation stdout ----

	thread 'test::test_massive_task_creation' panicked at 'atomic_active_count: 2', lib.rs:553:8
@bblancha
Copy link
Contributor

bblancha commented Jul 9, 2017

When #63 gets merged, we should be able use use it to eliminate the race.

https://github.com/bblancha/rust-threadpool/blob/massive_task_creation_fix/lib.rs#L599

@frewsxcv
Copy link
Collaborator Author

#63 has merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants