Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional use of Github secrets to workaround rate limits #867

Merged
merged 1 commit into from Apr 25, 2020

Conversation

palfrey
Copy link
Collaborator

@palfrey palfrey commented Apr 3, 2020

This would fix #859 (429 errors from Github) but I don't have enough permissions to add a new secret value to Travis.

@luciusmagn Any thoughts? Do you have enough access for this?

@palfrey
Copy link
Collaborator Author

palfrey commented Apr 11, 2020

@kud1ing Do you still have enough access to add a secret? Relatedly, I don't appear to be able to restart Travis builds anymore which I used to be able to :(

@kud1ing
Copy link
Contributor

kud1ing commented Apr 11, 2020

Hi, no i am sorry. This is bound to the organization, which i've left.

@palfrey
Copy link
Collaborator Author

palfrey commented Apr 21, 2020

@Manishearth Can you help here?

@Manishearth
Copy link
Collaborator

Can't secrets be added to the travis.yml?

I'm uncomfortable with adding my own account secrets and don't have time to make a dummy account.

@palfrey
Copy link
Collaborator Author

palfrey commented Apr 21, 2020

I'm ok with adding my own secrets to the travis.yml, but only if they're encrypted with the standard Travis encryption stuff. I can't do that however as I don't have enough access on travis, probably because I don't have enough access on this repository. If that can be fixed, I can fix the rest of things myself.

@badboy
Copy link

badboy commented Apr 22, 2020

We should be able to make @palfrey an admin on this repo. @Manishearth, you're good with that?

@palfrey
Copy link
Collaborator Author

palfrey commented Apr 25, 2020

@badboy @Manishearth Any further thoughts on this?

@Manishearth
Copy link
Collaborator

Yeah, this has been in my queue, i just have a ton of notifications to deal with.

You've been maintaining this pretty well, I'm okay with granting admin access. Please use it responsibly 😄

@palfrey
Copy link
Collaborator Author

palfrey commented Apr 25, 2020

Cool, thanks. I've added the secrets now (in the Travis UI, not the .travis.yml)

@palfrey palfrey merged commit 2dfb078 into rust-unofficial:master Apr 25, 2020
@palfrey palfrey deleted the add-github-secrets branch April 25, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

429 errors from Github
4 participants