Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it assumes cargo new makes a lib but it makes a bin #93

Closed
robinderksen opened this issue Jun 6, 2018 · 10 comments
Closed

it assumes cargo new makes a lib but it makes a bin #93

robinderksen opened this issue Jun 6, 2018 · 10 comments

Comments

@robinderksen
Copy link

On the first page, the first instructions are
cargo new lists
cd lists

cargo new by default makes a bin, not a lib. The beginning of chapter 2 seems to indicate a lib was expected here.

I propose to change the above code in chapter 1 to include --lib

@mbudde
Copy link
Contributor

mbudde commented Jun 7, 2018

This has already been fixed in #91 but the website is still on an old version apparently. @gankro could you upload a new version?

@Gankra
Copy link
Collaborator

Gankra commented Jun 8, 2018

@edunham is the one with deploy perms

@weiss-uni-lib-trier
Copy link

Update on this would be appreciated. I stumbled over this issue too.

@sdht0
Copy link

sdht0 commented Feb 27, 2019

Another ping. It'd be good to update the website to handle Rust 2018. Thanks!

@Manishearth
Copy link
Collaborator

Should we just rehost to rust-unofficial.github.io?

@Gankra
Copy link
Collaborator

Gankra commented Mar 6, 2019

I don't know enough about our infra to say what should be done with this.

@sdht0
Copy link

sdht0 commented Mar 6, 2019

Looks like https://rust-unofficial.github.io/too-many-lists is already working via Travis. Maybe the old one can just be redirected to this for now?

@sdht0
Copy link

sdht0 commented Mar 28, 2019

I think this issue can be closed now?

@Gankra Gankra closed this as completed Mar 28, 2019
@Gankra
Copy link
Collaborator

Gankra commented Mar 28, 2019

I was leaving this open as a reminder to setup redirects, but yeah i finally got that done.

@sdht0
Copy link

sdht0 commented Mar 28, 2019

Thanks! I did check that the redirects were working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants