Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust dependencies to their latest version #238

Open
andreeaflorescu opened this issue Mar 29, 2023 · 2 comments
Open

Update Rust dependencies to their latest version #238

andreeaflorescu opened this issue Mar 29, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andreeaflorescu
Copy link
Member

The purpose of this issue is to make the CI pass on main. Right now it fails because of a cargo audit failure.

Steps for solving this issue:

  1. Identify what versions are outdated (probably most of them). To check what versions are outdated, you can install cargo outdated and run the command.
cargo install cargo-outdated
cargo outdated
  1. Update the versions of the crates in the corresponding Cargo.toml files keeping in mind that we should use the latest everywhere. If a crate is a dependency of 2 local vmm-reference crates, then both of them should point to the same value.
  2. Run cargo outdated to make sure you didn't miss any updates.

At the end of this work cargo audit should pass in the CI.

@andreeaflorescu andreeaflorescu added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 29, 2023
@eddie-m-m
Copy link

eddie-m-m commented Mar 31, 2023

I'm new (like, really new) to VCS. I updated all the Cargo.toml files I could find (after some premature and meandering commits). My rust-analyzer tells me all crates are updated and the cargo outdated does as well. I'm still breaking the build though (?).

I have been trying to build on Windows. I believe that may be problematic. I replicated the work on WSL Debian and still am breaking the build.

@andreeaflorescu
Copy link
Member Author

Hey @eddiemMenefee, just updating the Cargo.toml to the latest versions is not enough. You have to also look at what the failures are and address them. Some APIs have changed and the calls to those APIs need to be updated. One of the big changes is the virtio queue one where the memory is now passed directly to the methods that need it as opposed to having it as part of the Queue object. This particular change I think is a bit harder to tackle, I might be able to provide a commit that fixes that. For the rest, if they're rust-vmm crates, you can look at the changelog to see what changed between the version that you're upgrading to compared to the previous version, and understand what needs to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants