ndk-build: Support android:resizeableActivity
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
android:resizeableActivityandroid:resizeableActivity
MarijnS95
reviewed
Sep 5, 2022
MarijnS95
reviewed
Sep 5, 2022
MarijnS95
reviewed
Sep 5, 2022
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
|
@MarijnS95 Thanks for your review. I've addressed your feedback, please have another look. |
MarijnS95
reviewed
Sep 5, 2022
|
Incidentally, looks like users have already previously (incorrectly) assumed that this attribute was supported: |
|
@RagnarListig I don't fully remember if the previous implementation serialized all tables parsed from TOML into XML, which won't suffer from that. Regardless, that's what you sometimes get with external contributions 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial pull request to add support for the
android:resizeableActivityattribute on<activity>, needed e.g. for manifests for the Oculus Quest VR headset.