ndk-build: Provide adb path to ndk-gdb
#343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
adb path to ndk-gdbadb path to ndk-gdb
MarijnS95
force-pushed
the
provide-adb-path-to-ndk-gdb
branch
from
5818030
to
8cc835a
Compare
`adb` is not necessarily available in `PATH`, hence why `cargo-apk` and `ndk-build` detect and use this executable from the SDK path. We should do the same for `ndk-gdb` which strangely doesn't search for `adb` within the SDK it resides in.
MarijnS95
force-pushed
the
provide-adb-path-to-ndk-gdb
branch
from
8cc835a
to
e993c28
Compare
|
Tested on Windows and Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adbis not necessarily available inPATH, hence whycargo-apkandndk-builddetect and use this executable from the SDK path. We should do the same forndk-gdbwhich strangely doesn't search foradbwithin the SDK it resides in.