ndk-build: Remove unparsable quotes from Android.mk for ndk-gdb
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows it seems the `ndk-gdb.py` script that invokes `make` to dump the variables from `Android.mk` fails to strip quotation marks from the file correctly, resulting in erroneous output like (notice double quotes at the end of the path): OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'android-ndk-rs\\target\\debug\\apk\\examples\\""' And: Application cannot run on the selected device. Application ABIs: "arm64-v8a" Device ABIs: arm64-v8a, armeabi-v7a, armeabi Solve this by removing the quotes, allowing `ndk-gdb` to launch sucessfully.
|
Tested on Windows and Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows it seems the
ndk-gdb.pyscript that invokesmaketo dump the variables fromAndroid.mkfails to strip quotation marks from the file correctly, resulting in erroneous output like (notice double quotes at the end of the path):And:
Solve this by removing the quotes, allowing
ndk-gdbto launch sucessfully.